boards: fobe: add FoBE Quill nRF52840 Mesh board #94292
Open
+656
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
decsny,
galak,
henrikbrixandersen,
mbolivar,
mnkp and
rruuaanng
dsseng
reviewed
Aug 9, 2025
boards/fobe/quill_nrf52840_mesh/quill_nrf52840_mesh_common.dtsi
Outdated
Show resolved
Hide resolved
rruuaanng
reviewed
Aug 9, 2025
boards/fobe/quill_nrf52840_mesh/quill_nrf52840_mesh_common.dtsi
Outdated
Show resolved
Hide resolved
boards/fobe/quill_nrf52840_mesh/quill_nrf52840_mesh_common.dtsi
Outdated
Show resolved
Hide resolved
boards/fobe/quill_nrf52840_mesh/quill_nrf52840_mesh_common.dtsi
Outdated
Show resolved
Hide resolved
boards/fobe/quill_nrf52840_mesh/quill_nrf52840_mesh_common.dtsi
Outdated
Show resolved
Hide resolved
boards/fobe/quill_nrf52840_mesh/quill_nrf52840_mesh_common.dtsi
Outdated
Show resolved
Hide resolved
boards/fobe/quill_nrf52840_mesh/quill_nrf52840_mesh_common.dtsi
Outdated
Show resolved
Hide resolved
boards/fobe/quill_nrf52840_mesh/quill_nrf52840_mesh_common.dtsi
Outdated
Show resolved
Hide resolved
chihosin
force-pushed
the
board/fobe_quill_nrf52840_mesh
branch
from
b58689e to
7f99b67
Compare
chihosin
force-pushed
the
board/fobe_quill_nrf52840_mesh
branch
from
7f99b67 to
10d3432
Compare
nordicjm
requested changes
Aug 11, 2025
boards/fobe/quill_nrf52840_mesh/doc/img/quill_nrf52840_mesh_pinout.png
Outdated
Show resolved
Hide resolved
boards/fobe/quill_nrf52840_mesh/doc/img/quill_nrf52840_mesh.png
Outdated
Show resolved
Hide resolved
boards/fobe/quill_nrf52840_mesh/quill_nrf52840_mesh-pinctrl.dtsi
Outdated
Show resolved
Hide resolved
chihosin
force-pushed
the
board/fobe_quill_nrf52840_mesh
branch
2 times, most recently
from
00a8b55 to
9cf22ba
Compare
nordicjm
previously approved these changes
Aug 12, 2025
dsseng
approved these changes
Aug 12, 2025
boards/fobe/quill_nrf52840_mesh/quill_nrf52840_mesh_common.dtsi
Outdated
Show resolved
Hide resolved
boards/fobe/quill_nrf52840_mesh/quill_nrf52840_mesh_common.dtsi
Outdated
Show resolved
Hide resolved
boards/fobe/quill_nrf52840_mesh/quill_nrf52840_mesh_common.dtsi
Outdated
Show resolved
Hide resolved
boards/fobe/quill_nrf52840_mesh/quill_nrf52840_mesh_common.dtsi
Outdated
Show resolved
Hide resolved
Why not? But I’m having some network issues, so I might be a bit late. |
chihosin
force-pushed
the
board/fobe_quill_nrf52840_mesh
branch
from
9cf22ba to
293761c
Compare
dsseng
approved these changes
Aug 12, 2025
chihosin
force-pushed
the
board/fobe_quill_nrf52840_mesh
branch
from
293761c to
3f823bd
Compare
|
Fixed some workflow build warning. |
kartben
requested changes
Aug 12, 2025
boards/fobe/quill_nrf52840_mesh/doc/img/quill_nrf52840_mesh.webp
Outdated
Show resolved
Hide resolved
|
@chihosin by the way, could you please fix your sign-off for compliance to pass? Do it like |
chihosin
force-pushed
the
board/fobe_quill_nrf52840_mesh
branch
2 times, most recently
from
fdd4a7b to
4fdc525
Compare
|
@chihosin Please refrain from marking request for changes as resolved unless it's for trivial suggestoin where you apply suggestions verbatim (which to be clear, is the case for several of them, but for the others it's just difficult for reviewers to come back and remember what they need to "re"-check) - https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#workflow-suggestions-that-help-reviewers |
kartben
reviewed
Aug 13, 2025
boards/fobe/quill_nrf52840_mesh/doc/img/quill_nrf52840_mesh.webp
Outdated
Show resolved
Hide resolved
This commit introduces the FoBE Quill nRF52840 Mesh board configuration, including device tree files, Kconfig settings, and necessary documentation. It also adds GPIO header definitions and updates vendor prefixes for proper identification. Signed-off-by: Chiho Sin <[email protected]>
chihosin
force-pushed
the
board/fobe_quill_nrf52840_mesh
branch
from
4fdc525 to
3647e5a
Compare
|
kartben
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the FoBE Quill nRF52840 Mesh board configuration, including device tree files, Kconfig settings, and necessary documentation. It also adds GPIO header definitions and updates vendor prefixes for proper identification.
Tested on zephyr samples.